Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence mypy errors for files outside those specified #6512

Merged
merged 2 commits into from Dec 11, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Dec 10, 2019

This is required for the database config splitting up PR, as a file in config/ needs to import a class in storage/, which then leads to lots and lots of errors.

erikjohnston added 2 commits Dec 6, 2019
@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Dec 10, 2019
Copy link
Member

richvdh left a comment

a file in config/ needs to import a class in storage/

this feels like a bad thing architecturally, tbh.

but otherwise lgtm

@erikjohnston erikjohnston merged commit 239d86a into develop Dec 11, 2019
22 checks passed
22 checks passed
buildkite/synapse Build #6040 passed (27 minutes, 58 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 35 seconds)
Details
buildkite/synapse/check-style Passed (2 minutes, 7 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/mypy Passed (24 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (16 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 24 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 39 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 51 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 40 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes, 44 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 36 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 19 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (2 minutes, 15 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (2 minutes, 11 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (13 minutes, 46 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (12 minutes, 56 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (11 minutes, 3 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (11 minutes, 42 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (11 minutes, 2 seconds)
Details
@erikjohnston

This comment has been minimized.

Copy link
Member Author

erikjohnston commented Dec 11, 2019

a file in config/ needs to import a class in storage/

this feels like a bad thing architecturally, tbh.

but otherwise lgtm

Its not ideal, but I think configuring mypy like this will help us expand our mypy coverage anyway

@erikjohnston erikjohnston deleted the erikj/silence_mypy branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.