Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port some of FederationHandler to async/await #6517

Merged
merged 5 commits into from Dec 11, 2019
Merged

Port some of FederationHandler to async/await #6517

merged 5 commits into from Dec 11, 2019

Conversation

@richvdh
Copy link
Member

richvdh commented Dec 10, 2019

Sorry this is a bit of a big diff. it might be easier to review it by commit.

@richvdh richvdh force-pushed the rav/event_auth/13 branch 2 times, most recently from d7dc51a to 1ac70c1 Dec 10, 2019
richvdh added 5 commits Dec 10, 2019
PaginationHandler.get_messages is only called by RoomMessageListRestServlet,
which is async.

Chase the code path down from there:
 - FederationHandler.maybe_backfill (and nested try_backfill)
 - FederationHandler.backfill
and associated functions:
 * on_receive_pdu
 * handle_queued_pdus
 * get_missing_events_for_pdu
... and _get_events_from_store_or_dest
also fix user_joined_room to consistently return deferreds
@richvdh richvdh force-pushed the rav/event_auth/13 branch from 1ac70c1 to 5324bc2 Dec 11, 2019
@richvdh richvdh requested a review from matrix-org/synapse-core Dec 11, 2019
@richvdh richvdh merged commit 894d2ad into develop Dec 11, 2019
22 checks passed
22 checks passed
buildkite/synapse Build #6086 passed (39 minutes, 5 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 20 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 52 seconds)
Details
buildkite/synapse/isort Passed (14 seconds)
Details
buildkite/synapse/mypy Passed (48 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (13 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 49 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 14 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (7 minutes, 40 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 33 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes, 46 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (19 minutes, 3 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 47 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 8 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 41 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (12 minutes, 40 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (16 minutes, 34 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (11 minutes, 34 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (11 minutes, 51 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (12 minutes, 52 seconds)
Details
@richvdh richvdh deleted the rav/event_auth/13 branch Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.