Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to allow profile queries without sharing a room #6523

Merged
merged 8 commits into from Dec 16, 2019

Conversation

@Half-Shot
Copy link
Contributor

Half-Shot commented Dec 11, 2019

This is a port of matrix-org/synapse-dinsic#18 to mainline, with an adjustment to make the config key spell out with it does.

@Half-Shot Half-Shot changed the base branch from master to develop Dec 11, 2019
@Half-Shot Half-Shot changed the title Hs/config limit profile reqs Add option to allow profile querys without sharing a room Dec 11, 2019
@Half-Shot Half-Shot requested a review from anoadragon453 Dec 11, 2019
@rxl881

This comment has been minimized.

Copy link

rxl881 commented Dec 11, 2019

It would be very useful to get this merged asap from a Modular POV, as it is breaking some profile lookups for some users from the Synapse admin dashboard.

Half-Shot added 3 commits Dec 11, 2019
@babolivier babolivier requested review from matrix-org/synapse-core and removed request for anoadragon453 Dec 16, 2019
Copy link
Member

anoadragon453 left a comment

lgtm otherwise

changelog.d/6523.feature Outdated Show resolved Hide resolved
synapse/config/server.py Outdated Show resolved Hide resolved
synapse/config/server.py Outdated Show resolved Hide resolved
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@Half-Shot Half-Shot changed the title Add option to allow profile querys without sharing a room Add option to allow profile queries without sharing a room Dec 16, 2019
@anoadragon453 anoadragon453 merged commit bfb9565 into develop Dec 16, 2019
22 checks passed
22 checks passed
buildkite/synapse Build #6184 passed (21 minutes, 19 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 35 seconds)
Details
buildkite/synapse/check-style Passed (2 minutes, 6 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/mypy Passed (49 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 59 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 41 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 47 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 21 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes, 32 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 30 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 19 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 20 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 24 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (13 minutes, 21 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (15 minutes, 3 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (11 minutes, 19 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (10 minutes, 53 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (12 minutes, 33 seconds)
Details
@hawkowl hawkowl deleted the hs/config-limit-profile-reqs branch Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.