/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Enable guest access for private rooms by default #653

Merged
merged 1 commit into from Dec 5, 2016

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Mar 17, 2016

No description provided.

@erikjohnston erikjohnston assigned NegativeMjark Mar 17, 2016

@erikjohnston erikjohnston referenced this pull request in vector-im/riot-web Mar 17, 2016

Closed

Starting a chat from memberlist should allow guest access by default #1135

@erikjohnston
Enable guest access for private rooms by default

Some checks were not successful

2 errored, 1 failing, and 7 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #32 origin/erikj/preset_guest_join failed in 2.2 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #164 origin/erikj/preset_guest_join failed in 20 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #161 origin/erikj/preset_guest_join succeeded in 28 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #165 origin/erikj/preset_guest_join succeeded in 4 min 12 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #206 origin/erikj/preset_guest_join succeeded in 1 min 7 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
3bb3f02
@NegativeMjark
Contributor

NegativeMjark commented Mar 18, 2016

Do we need to update the docs at https://github.com/matrix-org/matrix-doc/blob/master/api/client-server/create_room.yaml#L130 ?
@NegativeMjark
Contributor

NegativeMjark commented Mar 18, 2016

LGTM

@NegativeMjark NegativeMjark assigned erikjohnston and unassigned NegativeMjark Mar 30, 2016

@ara4n ara4n referenced this pull request in vector-im/riot-web Aug 26, 2016

Closed

can't start PMs with guests #1980

@erikjohnston
Owner

erikjohnston commented Dec 5, 2016

@matrixbot retest this please
@erikjohnston
Owner

erikjohnston commented Dec 5, 2016

@matrixbot retest this please

@erikjohnston erikjohnston merged commit 9609c91 into develop Dec 5, 2016
3 of 10 checks passed

3 of 10 checks passed

Sytest Dendron (Commit) Build #32 origin/erikj/preset_guest_join failed in 2.2 sec
Details
Sytest Postgres (Commit) Build #164 origin/erikj/preset_guest_join failed in 20 sec
Details
Flake8 + Packaging (Merged PR) Build triggered. sha1 is merged.
Details
Sytest Dendron (Merged PR) Build triggered. sha1 is merged.
Details
Sytest Postgres (Merged PR) Build triggered. sha1 is merged.
Details
Sytest SQLite (Merged PR) Build triggered. sha1 is merged.
Details
Unit Tests (Merged PR) Build triggered. sha1 is merged.
Details
Flake8 + Packaging (Commit) Build #161 origin/erikj/preset_guest_join succeeded in 28 sec
Details
Sytest SQLite (Commit) Build #165 origin/erikj/preset_guest_join succeeded in 4 min 12 sec
Details
Unit Tests (Commit) Build #206 origin/erikj/preset_guest_join succeeded in 1 min 7 sec
Details

@erikjohnston erikjohnston deleted the erikj/preset_guest_join branch Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment