Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mypy version #6537

Merged
merged 4 commits into from Dec 13, 2019
Merged

Bump mypy version #6537

merged 4 commits into from Dec 13, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Dec 12, 2019

Based on #6534.

Fixes #6535.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Dec 12, 2019
Copy link
Member

richvdh left a comment

lgtm

@@ -171,7 +171,7 @@ def pauseProducing(self):

def stopProducing(self):
self._paused = True
self._buffer = None
self._buffer = deque()

This comment has been minimized.

Copy link
@richvdh

richvdh Dec 13, 2019

Member

.clear, maybe?

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Dec 13, 2019

Author Member

For things that don't get reused I tend to bias to creating new objects simply to help ensure the underlying resources gets GC'ed, though that might be a bit spurious

This comment has been minimized.

Copy link
@richvdh

richvdh Dec 13, 2019

Member

hrm. I'd be more concerned about the overhead of creating new objects.

I think the whole thing's academic here.

@erikjohnston erikjohnston merged commit 5cadbd9 into develop Dec 13, 2019
22 checks passed
22 checks passed
buildkite/synapse Build #6129 passed (20 minutes, 40 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 32 seconds)
Details
buildkite/synapse/check-style Passed (2 minutes, 8 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/mypy Passed (32 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (21 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 25 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 36 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 58 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 59 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 13 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 1 second)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 39 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 14 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (13 minutes, 30 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (14 minutes, 16 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (11 minutes, 5 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (11 minutes, 47 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (11 minutes, 57 seconds)
Details
@richvdh richvdh mentioned this pull request Dec 13, 2019
@erikjohnston erikjohnston deleted the erikj/bump_mypy_version branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.