Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delta file to fix missing default table data #6555

Merged
merged 4 commits into from Dec 18, 2019
Merged

Conversation

@anoadragon453
Copy link
Member

anoadragon453 commented Dec 16, 2019

Fixes #6311

The above issue came about because we missed an INSERT statement when making the 56 full schema. Synapse expected that row to exist, and had an UPDATE statement for it. When we missed the INSERT, the UPDATE just failed silently.

#6363 fixed it by doing some INSERT/UPDATE stuff in python, but it's not efficient and is prone to race conditions. This PR reverts that commit, and instead just adds another delta file, which is a cleaner fix.

Reverts #6363

@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Dec 16, 2019
@anoadragon453 anoadragon453 self-assigned this Dec 16, 2019
@anoadragon453 anoadragon453 requested a review from richvdh Dec 16, 2019
Copy link
Member

richvdh left a comment

lgtm

@anoadragon453 anoadragon453 merged commit 7963ca8 into develop Dec 18, 2019
22 checks passed
22 checks passed
buildkite/synapse Build #6192 passed (21 minutes, 2 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 22 seconds)
Details
buildkite/synapse/check-style Passed (2 minutes, 14 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/mypy Passed (32 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (19 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 31 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 32 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (9 minutes, 5 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 28 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 28 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (8 minutes, 6 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 25 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 18 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (12 minutes, 17 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (14 minutes, 30 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (10 minutes, 14 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (11 minutes, 56 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (12 minutes, 12 seconds)
Details
@anoadragon453 anoadragon453 deleted the anoa/device_delta branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.