Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up startup for the pusher #6558

Merged
merged 7 commits into from Dec 18, 2019
Merged

Clean up startup for the pusher #6558

merged 7 commits into from Dec 18, 2019

Conversation

@richvdh
Copy link
Member

richvdh commented Dec 17, 2019

There are several separate but related commits here; suggest reviewing them independently. It's all about trying to stop the pusher from logging a load of exceptions at startup.

richvdh added 5 commits Dec 16, 2019
`str.decode()` doesn't exist on python3, so presumably this code was doing
nothing
When we get a row with unparsable json, drop the row, rather than returning a
row with null `data`, which will then cause an explosion later on.
Log the ID to help us understand the problem
We know we'll have a `data` member, since that comes from the database. What we
*don't* know is if that is a dict, and if that has a `brand` member, and if
that member is a string.
@richvdh richvdh requested a review from matrix-org/synapse-core Dec 17, 2019
richvdh added 2 commits Dec 17, 2019
@richvdh richvdh merged commit d6752ce into develop Dec 18, 2019
22 checks passed
22 checks passed
buildkite/synapse Build #6206 passed (20 minutes, 57 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 22 seconds)
Details
buildkite/synapse/check-style Passed (2 minutes, 7 seconds)
Details
buildkite/synapse/isort Passed (44 seconds)
Details
buildkite/synapse/mypy Passed (33 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (38 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 54 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 48 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 40 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 41 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes, 39 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 16 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 23 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 36 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 28 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (13 minutes, 7 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (15 minutes, 28 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (11 minutes, 30 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (9 minutes, 46 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (12 minutes, 28 seconds)
Details
@richvdh richvdh deleted the rav/clean_up_pusher_start branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.