Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port some admin handlers to async/await #6559

Merged
merged 3 commits into from Dec 19, 2019
Merged

Port some admin handlers to async/await #6559

merged 3 commits into from Dec 19, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Dec 17, 2019

No description provided.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Dec 17, 2019
@@ -119,8 +113,7 @@ def set_user_server_admin(self, user, admin):
"""
return self.store.set_server_admin(user, admin)

@defer.inlineCallbacks
def export_user_data(self, user_id, writer):
async def export_user_data(self, user_id, writer):

This comment has been minimized.

Copy link
@richvdh

richvdh Dec 17, 2019

Member

this one looks like it's got a yield in admin_cmd.py

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Dec 19, 2019

Author Member

Oh good point. Apparently even searching for function references correctly was too much for me on Tuesday

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Dec 19, 2019
@erikjohnston erikjohnston merged commit 3d46124 into develop Dec 19, 2019
22 checks passed
22 checks passed
buildkite/synapse Build #6225 passed (26 minutes, 19 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 23 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 56 seconds)
Details
buildkite/synapse/isort Passed (37 seconds)
Details
buildkite/synapse/mypy Passed (28 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (13 seconds)
Details
buildkite/synapse/packaging Passed (23 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (10 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 30 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (7 minutes, 47 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 41 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (9 minutes, 46 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (10 minutes, 1 second)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 44 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 51 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 51 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (11 minutes, 4 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (12 minutes, 31 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (9 minutes, 40 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (9 minutes, 45 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (11 minutes, 40 seconds)
Details
@erikjohnston erikjohnston deleted the erikj/async_await branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.