/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Dedupe requested event list in _get_events #656

Merged
merged 3 commits into from Mar 18, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Mar 18, 2016

No description provided.

erikjohnston added some commits Mar 18, 2016

@erikjohnston
Dedupe requested event list in _get_events
67ed806
@erikjohnston
Don't assume existence of event_id in __str__

Some checks were not successful

2 errored and 6 successful checks
@matrixbot
Sytest Postgres (Commit) — Build #167 origin/erikj/get_event failed in 5 min 17 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #168 origin/erikj/get_event failed in 4 min 13 sec
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #164 origin/erikj/get_event succeeded in 28 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #209 origin/erikj/get_event succeeded in 1 min 8 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
58e207c

@erikjohnston erikjohnston assigned NegativeMjark Mar 18, 2016

@NegativeMjark
Contributor

NegativeMjark commented Mar 18, 2016

LGTM apart from the sytests.
@erikjohnston
Merge branch 'develop' of github.com:matrix-org/synapse into erikj/ge… 
…t_event

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #165 origin/erikj/get_event succeeded in 27 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #168 origin/erikj/get_event succeeded in 5 min 13 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #169 origin/erikj/get_event succeeded in 4 min 23 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #210 origin/erikj/get_event succeeded in 1 min 16 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
8595ff7

erikjohnston added a commit that referenced this pull request Mar 18, 2016

@erikjohnston
Merge pull request #656 from matrix-org/erikj/get_event 
Dedupe requested event list in _get_events

Some checks were not successful

1 errored and 3 successful checks
@matrixbot
Sytest SQLite (Commit) — Build #170 origin/develop failed in 4 min 9 sec
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #166 origin/develop succeeded in 29 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #169 origin/develop succeeded in 5 min 0 sec
Details
@matrixbot
Unit Tests (Commit) — Build #211 origin/develop succeeded in 1 min 11 sec
Details
7f79a64

@erikjohnston erikjohnston merged commit 7f79a64 into develop Mar 18, 2016
8 checks passed

8 checks passed

Flake8 + Packaging (Commit) Build #165 origin/erikj/get_event succeeded in 27 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #168 origin/erikj/get_event succeeded in 5 min 13 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #169 origin/erikj/get_event succeeded in 4 min 23 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #210 origin/erikj/get_event succeeded in 1 min 16 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the erikj/get_event branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment