Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change EventContext to use the Storage class #6564

Merged
merged 3 commits into from Dec 20, 2019
Merged

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Dec 18, 2019

This is needed as get_state_ids_for_group will be moving out of the main data store.

@@ -295,28 +298,30 @@ class _AsyncEventContextImpl(EventContext):
that was replaced.
"""

# This needs to have a default as we're inheriting
_storage = attr.ib(default=None)

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Dec 18, 2019

Author Member

Annoyingly this needs a default, otherwise attr complains (as we're inheriting from a attr class which have attributes with default values). I'm not sure if there's another way round this beyond removing all the defaults.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Dec 18, 2019
Copy link
Member

richvdh left a comment

lgtm otherwise

synapse/events/snapshot.py Show resolved Hide resolved
@erikjohnston erikjohnston merged commit fa780e9 into develop Dec 20, 2019
22 checks passed
22 checks passed
buildkite/synapse Build #6239 passed (24 minutes, 2 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 30 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 41 seconds)
Details
buildkite/synapse/isort Passed (37 seconds)
Details
buildkite/synapse/mypy Passed (31 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (39 seconds)
Details
buildkite/synapse/packaging Passed (21 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 35 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 15 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (7 minutes, 11 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 39 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (10 minutes)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (9 minutes, 47 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 38 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 35 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 37 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (11 minutes, 13 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (12 minutes, 21 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (9 minutes, 47 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (9 minutes, 49 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (10 minutes, 51 seconds)
Details
@erikjohnston erikjohnston deleted the erikj/context_storage branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.