/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add published room list edit API #657

Merged
merged 3 commits into from Mar 22, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@erikjohnston @NegativeMjark @ara4n
@erikjohnston
Owner

erikjohnston commented Mar 21, 2016

No description provided.

@erikjohnston
Add published room list edit API

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #170 origin/erikj/roomlist succeeded in 29 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #173 origin/erikj/roomlist succeeded in 5 min 25 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #174 origin/erikj/roomlist succeeded in 4 min 30 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #215 origin/erikj/roomlist succeeded in 1 min 5 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
3e7fac0

@erikjohnston erikjohnston assigned NegativeMjark Mar 21, 2016

@ara4n
an invalide is something else...

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #172 origin/erikj/roomlist succeeded in 28 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #175 origin/erikj/roomlist succeeded in 5 min 12 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #176 origin/erikj/roomlist succeeded in 4 min 19 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #217 origin/erikj/roomlist succeeded in 1 min 10 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
d365469

This was referenced Mar 22, 2016

Merged
Closed

@NegativeMjark NegativeMjark commented on the diff Mar 22, 2016

View full changes
synapse/handlers/directory.py
@@ -317,3 +317,19 @@ def _user_can_delete_alias(self, alias, user_id):
is_admin = yield self.auth.is_server_admin(UserID.from_string(user_id))
defer.returnValue(is_admin)
+
+ @defer.inlineCallbacks
+ def edit_published_room_list(self, requester, room_id, visibility):
@NegativeMjark

NegativeMjark Mar 22, 2016

Contributor

maybe add some doc string
@NegativeMjark
Contributor

NegativeMjark commented Mar 22, 2016

Code LGTM. Some sytests would be nice. ["published", "unpublished"] or ["published", "hidden"] might be better words than ["public", "private"].
@erikjohnston
Owner

erikjohnston commented Mar 22, 2016

Some sytests would be nice.

That's on the radar

["published", "unpublished"] or ["published", "hidden"] might be better words than ["public", "private"].

Unpublished might be better than private, but the intent here is to allow various other values for the visibility, e.g. "local_server" or whatever, so I don't think "published" really conveys what's going on.
@erikjohnston
Doc string

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #175 origin/erikj/roomlist succeeded in 27 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #178 origin/erikj/roomlist succeeded in 5 min 33 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #179 origin/erikj/roomlist succeeded in 4 min 33 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #220 origin/erikj/roomlist succeeded in 1 min 1 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
97785bf

erikjohnston added a commit that referenced this pull request Mar 22, 2016

@erikjohnston
Merge pull request #657 from matrix-org/erikj/roomlist 
Add published room list edit API

All checks have passed

4 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #176 origin/develop succeeded in 28 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #179 origin/develop succeeded in 4 min 46 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #180 origin/develop succeeded in 3 min 48 sec
Details
@matrixbot
Unit Tests (Commit) — Build #221 origin/develop succeeded in 1 min 10 sec
Details
d6ac752

@erikjohnston erikjohnston merged commit d6ac752 into develop Mar 22, 2016
8 checks passed

8 checks passed

Flake8 + Packaging (Commit) Build #175 origin/erikj/roomlist succeeded in 27 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #178 origin/erikj/roomlist succeeded in 5 min 33 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #179 origin/erikj/roomlist succeeded in 4 min 33 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #220 origin/erikj/roomlist succeeded in 1 min 1 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the erikj/roomlist branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment