/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove some unused parameters from persist_event #658

Merged
merged 2 commits into from Mar 22, 2016

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@NegativeMjark @erikjohnston @oddvar
@NegativeMjark
Contributor

NegativeMjark commented Mar 21, 2016

Since the backfill code uses persist_events rather than persist_event there isn't any code that actually passes a backfill parameter to persist_event.

Additionally _handle_new_event took a current_state parameter, however that parameter was always None, so can be removed.

NegativeMjark added some commits Mar 21, 2016

@NegativeMjark
remove unused current_state variable from on_receive_pdu
58f8226
@NegativeMjark
Remove unused backfilled parameter from persist_event

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #171 origin/markjh/cleanup succeeded in 28 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #174 origin/markjh/cleanup succeeded in 5 min 29 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #175 origin/markjh/cleanup succeeded in 4 min 32 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #216 origin/markjh/cleanup succeeded in 1 min 10 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
5244c0b

@NegativeMjark NegativeMjark assigned erikjohnston Mar 21, 2016

@oddvar oddvar added the in progress label Mar 21, 2016

@erikjohnston
Owner

erikjohnston commented Mar 22, 2016

LGTM

NegativeMjark added a commit that referenced this pull request Mar 22, 2016

@NegativeMjark
Merge pull request #658 from matrix-org/markjh/cleanup 
Remove some unused parameters from persist_event

All checks have passed

4 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #173 origin/develop succeeded in 26 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #176 origin/develop succeeded in 4 min 31 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #177 origin/develop succeeded in 3 min 12 sec
Details
@matrixbot
Unit Tests (Commit) — Build #218 origin/develop succeeded in 1 min 7 sec
Details
63137bb

@NegativeMjark NegativeMjark merged commit 63137bb into develop Mar 22, 2016
8 checks passed

8 checks passed

Flake8 + Packaging (Commit) Build #171 origin/markjh/cleanup succeeded in 28 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #174 origin/markjh/cleanup succeeded in 5 min 29 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #175 origin/markjh/cleanup succeeded in 4 min 32 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #216 origin/markjh/cleanup succeeded in 1 min 10 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@oddvar oddvar removed the in progress label Mar 22, 2016

@richvdh richvdh deleted the markjh/cleanup branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment