/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Don't cache events in _state_group_cache #660

Merged
merged 1 commit into from Mar 22, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@erikjohnston @NegativeMjark @oddvar
@erikjohnston
Owner

erikjohnston commented Mar 22, 2016

Instead, simply cache the event ids, relying on the event cache to cache
the actual events.

The problem was that while the state groups cache was limited in the
number of groups it could hold, each individual group could consist of
thousands of events.
@erikjohnston
Don't cache events in _state_group_cache 
Instead, simply cache the event ids, relying on the event cache to cache
the actual events.

The problem was that while the state groups cache was limited in the
number of groups it could hold, each individual group could consist of
thousands of events.

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #178 origin/erikj/state_cache succeeded in 29 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #181 origin/erikj/state_cache succeeded in 5 min 22 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #182 origin/erikj/state_cache succeeded in 4 min 27 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #223 origin/erikj/state_cache succeeded in 1 min 10 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
2c86187

@erikjohnston erikjohnston assigned NegativeMjark Mar 22, 2016

@oddvar oddvar added the in progress label Mar 22, 2016

@NegativeMjark
Contributor

NegativeMjark commented Mar 22, 2016

LGTM

erikjohnston added a commit that referenced this pull request Mar 22, 2016

@erikjohnston
Merge pull request #660 from matrix-org/erikj/state_cache 
Don't cache events in _state_group_cache

All checks have passed

4 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #179 origin/develop succeeded in 29 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #182 origin/develop succeeded in 5 min 37 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #183 origin/develop succeeded in 4 min 38 sec
Details
@matrixbot
Unit Tests (Commit) — Build #224 origin/develop succeeded in 1 min 7 sec
Details
fa2f96c

@erikjohnston erikjohnston merged commit fa2f96c into develop Mar 22, 2016
8 checks passed

8 checks passed

Flake8 + Packaging (Commit) Build #178 origin/erikj/state_cache succeeded in 29 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #181 origin/erikj/state_cache succeeded in 5 min 22 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #182 origin/erikj/state_cache succeeded in 4 min 27 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #223 origin/erikj/state_cache succeeded in 1 min 10 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@oddvar oddvar removed the in progress label Mar 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment