/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix membership count for BulkPushRuleEvaluator #661

Merged
merged 1 commit into from Mar 22, 2016

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@NegativeMjark @erikjohnston @oddvar
@NegativeMjark
Contributor

NegativeMjark commented Mar 22, 2016

Use get_users_in_room to count the number of room members rather than using read_receipts.
@NegativeMjark
Use get_users_in_room to count the number of room members rather than… 
… using read_receipts

Some checks were not successful

1 failing and 7 successful checks
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #180 origin/markjh/member_count succeeded in 25 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #183 origin/markjh/member_count succeeded in 5 min 14 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #184 origin/markjh/member_count succeeded in 4 min 20 sec
Details
@matrixbot
Unit Tests (Commit) — Build #225 origin/markjh/member_count succeeded in 1 min 8 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
5defb25

@NegativeMjark NegativeMjark assigned erikjohnston Mar 22, 2016

@oddvar oddvar added the in progress label Mar 22, 2016

@erikjohnston
Owner

erikjohnston commented Mar 22, 2016

lgtm

NegativeMjark added a commit that referenced this pull request Mar 22, 2016

@NegativeMjark
Merge pull request #661 from matrix-org/markjh/member_count 
Fix membership count for BulkPushRuleEvaluator

All checks have passed

4 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #181 origin/develop succeeded in 30 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #184 origin/develop succeeded in 5 min 45 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #185 origin/develop succeeded in 4 min 48 sec
Details
@matrixbot
Unit Tests (Commit) — Build #226 origin/develop succeeded in 1 min 14 sec
Details
cd9ba1e

@NegativeMjark NegativeMjark merged commit cd9ba1e into develop Mar 22, 2016
7 of 8 checks passed

7 of 8 checks passed

Sytest SQLite (Merged PR) Build finished.
Details
Flake8 + Packaging (Commit) Build #180 origin/markjh/member_count succeeded in 25 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #183 origin/markjh/member_count succeeded in 5 min 14 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #184 origin/markjh/member_count succeeded in 4 min 20 sec
Details
Unit Tests (Commit) Build #225 origin/markjh/member_count succeeded in 1 min 8 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@oddvar oddvar removed the in progress label Mar 22, 2016

@richvdh richvdh deleted the markjh/member_count branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment