Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the reconnect time when replication fails. #6617

Merged
merged 1 commit into from Jan 3, 2020

Conversation

@richvdh
Copy link
Member

richvdh commented Jan 2, 2020

The thinking here is that, if we wait a full 30 seconds, there's a good chance that there will be a huge volume of data waiting for us, so we'll get booted straight off again, and never successfully reconnect. OTOH even if we end up tight-looping on a reconnection, one connection every second isn't so bad.

This is all something of a sticking-plaster, of course: ideally there would be a separate "catching up mode" in which we wouldn't get booted straight off again.

Helps to mitigate #6602.

@richvdh richvdh requested a review from matrix-org/synapse-core Jan 2, 2020
Copy link
Member

babolivier left a comment

lgtm

@richvdh richvdh merged commit 6964ea0 into develop Jan 3, 2020
22 checks passed
22 checks passed
buildkite/synapse Build #6283 passed (16 minutes, 14 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 44 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 55 seconds)
Details
buildkite/synapse/isort Passed (50 seconds)
Details
buildkite/synapse/mypy Passed (32 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (19 seconds)
Details
buildkite/synapse/pipeline Passed (10 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (10 minutes, 22 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 2 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (7 minutes, 16 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 28 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (10 minutes, 12 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (10 minutes, 10 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 40 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 36 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 39 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (11 minutes, 2 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (12 minutes, 23 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (9 minutes, 46 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (11 minutes, 37 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (12 minutes, 30 seconds)
Details
@richvdh richvdh deleted the rav/reduce_replication_reconnect_time branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.