Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a bunch of unused code from event creation #6629

Merged
merged 8 commits into from Jan 6, 2020

Conversation

@richvdh
Copy link
Member

richvdh commented Jan 3, 2020

As per #6574, we were carefully pulling the event hashes out of event_reference_hashes and then throwing them away. We can simplify this. Sadly we can't kill off event_reference_hashes altogether because it turns out to be used elsewhere after all.

This PR is a series of commits each of which stands alone.

@richvdh richvdh requested a review from matrix-org/synapse-core Jan 3, 2020
@richvdh richvdh force-pushed the rav/kill_event_reference_hashes branch 2 times, most recently from 964123f to 27b58cb Jan 3, 2020
@richvdh richvdh force-pushed the rav/kill_event_reference_hashes branch from 27b58cb to 550b294 Jan 6, 2020
@richvdh richvdh merged commit 1807db5 into develop Jan 6, 2020
22 checks passed
22 checks passed
buildkite/synapse Build #6335 passed (33 minutes, 4 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 51 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 54 seconds)
Details
buildkite/synapse/isort Passed (28 seconds)
Details
buildkite/synapse/mypy Passed (32 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (27 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (10 minutes, 55 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 16 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 41 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (10 minutes, 5 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (10 minutes, 23 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (5 minutes, 50 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 50 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 16 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (17 minutes, 8 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (15 minutes, 55 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (10 minutes, 26 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (16 minutes, 34 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (10 minutes, 34 seconds)
Details
@richvdh richvdh deleted the rav/kill_event_reference_hashes branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.