Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions in the synchrotron worker log when events are rejected. #6645

Merged
merged 4 commits into from Jan 7, 2020

Conversation

@richvdh
Copy link
Member

richvdh commented Jan 6, 2020

Fixes #6428, I hope

@richvdh richvdh requested a review from matrix-org/synapse-core Jan 6, 2020

event = await self.store.get_event(
row.data.event_id, allow_rejected=True
)

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Jan 7, 2020

Member

Do we want to add handling/logging if we can't find an event while we're here?

This comment has been minimized.

Copy link
@richvdh

richvdh Jan 7, 2020

Author Member

not being able to find an event seems a sufficient edge-case that the existing logging is probably sufficient?

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Jan 7, 2020

Member

Oh right, yes, sorry thought we weren't catching exceptions.

@richvdh richvdh merged commit 1ff5491 into develop Jan 7, 2020
22 checks passed
22 checks passed
buildkite/synapse Build #6340 passed (29 minutes, 14 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 21 seconds)
Details
buildkite/synapse/check-style Passed (2 minutes, 10 seconds)
Details
buildkite/synapse/isort Passed (14 seconds)
Details
buildkite/synapse/mypy Passed (51 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (36 seconds)
Details
buildkite/synapse/packaging Passed (39 seconds)
Details
buildkite/synapse/pipeline Passed (10 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (10 minutes, 12 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 17 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (7 minutes, 15 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (5 minutes, 54 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (9 minutes, 57 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (9 minutes, 50 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (5 minutes, 48 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 37 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 47 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (11 minutes, 16 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (12 minutes, 4 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (11 minutes, 19 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (9 minutes, 55 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (11 minutes, 15 seconds)
Details
@richvdh richvdh deleted the rav/fix_synchrotron_error branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.