Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a background update to clear tombstoned rooms from the directory #6648

Merged
merged 2 commits into from Jan 7, 2020

Conversation

@richvdh
Copy link
Member

richvdh commented Jan 6, 2020

Fixes #6638

Based on #6647

@richvdh richvdh requested a review from matrix-org/synapse-core Jan 6, 2020
@richvdh richvdh force-pushed the rav/remove_tombstoned_rooms_from_directory branch from 44bd19e to dbcbd60 Jan 6, 2020
return len(rooms)

def set_room_is_public(self, room_id, is_public):
raise NotImplementedError()

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Jan 7, 2020

Member

They way we've done this elsewhere is to have RoomBackgroundUpdateStore inherit from a class with this function defined (which is tedious but at least avoids spurious NotImplementedError stuff). You could also use ABC metaclass stuff.

Or we can leave it as is but then I think it needs a comment here as to what on earth is going on

This comment has been minimized.

Copy link
@richvdh

richvdh Jan 7, 2020

Author Member

I've done the ABC thing. perhaps it's better now?

@richvdh richvdh requested a review from erikjohnston Jan 7, 2020
@richvdh richvdh force-pushed the rav/remove_tombstoned_rooms_from_directory branch from 8ded2e0 to a57c7b4 Jan 7, 2020
@richvdh richvdh force-pushed the rav/remove_tombstoned_rooms_from_directory branch from a57c7b4 to b55eb5a Jan 7, 2020
@richvdh richvdh merged commit 85db7f7 into develop Jan 7, 2020
3 of 8 checks passed
3 of 8 checks passed
buildkite/synapse Build #6358 started
Details
buildkite/synapse/check-sample-config Started...
Details
buildkite/synapse/check-style Started...
Details
buildkite/synapse/mypy Started...
Details
buildkite/synapse/newspaper-newsfile Started...
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/packaging Passed (17 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.