Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Support login using Javascript Web Tokens (JWT) #671
Conversation
matrixbot
commented
Mar 28, 2016
|
Can one of the admins verify this patch? |
matrixbot
commented
Mar 28, 2016
|
Can one of the admins verify this patch? |
matrixbot
commented
Mar 28, 2016
|
Can one of the admins verify this patch? |
matrixbot
commented
Mar 28, 2016
|
Can one of the admins verify this patch? |
nikriek
changed the title from
Support login using JWT tokens
to
Support login using Javascript Web Tokens (JWT)
Mar 28, 2016
|
Thanks! I'll take a look tomorrow. Sorry about the matrixbot thing, its a bug in how we're using jenkins :( |
|
@matrixbot ok to test |
erikjohnston
self-assigned this
Mar 28, 2016
|
(Jenkins is now complaining about the fact that jwt isn't installed.) |
|
Thanks! I'll fix these things if you are ok with the rest. |
|
I'm using PyJWT for JWT decoding, but I can't get it work with Synapse's dependency management. |
|
@matrixbot ok to test |
|
Some PEP8 warnings: http://matrix.org/jenkins/job/SynapseFlake8Packaging/129/violations/#pep8 |
|
LGTM (even jenkins is happy!) Our unit testing is a bit woeful atm; the bulk of the testing is done via sytest, which is written in Perl. Since this is a fairly simple PR I'm happy to just merge this now and for us to add a sytest for it down the line (unless you're happy writing Perl). Could you also follow https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#sign-off, i.e. adding |
|
Signed-off-by: Niklas Riekenbrauck nikriek@gmail.com |
|
Thanks! |
|
Thanks! Feel free to open a PR to add yourself to the AUTHORS.rst. |
nikriek commentedMar 28, 2016
The flow is not fully tested. I'm open for comments first.