Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support login using Javascript Web Tokens (JWT) #671

Merged
merged 1 commit into from Mar 29, 2016

Conversation

Projects
None yet
3 participants
Contributor

nikriek commented Mar 28, 2016

The flow is not fully tested. I'm open for comments first.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@nikriek nikriek changed the title from Support login using JWT tokens to Support login using Javascript Web Tokens (JWT) Mar 28, 2016

Owner

erikjohnston commented Mar 28, 2016

Thanks! I'll take a look tomorrow.

Sorry about the matrixbot thing, its a bug in how we're using jenkins :(

Owner

erikjohnston commented Mar 28, 2016

@matrixbot ok to test

@erikjohnston erikjohnston self-assigned this Mar 28, 2016

Owner

erikjohnston commented Mar 28, 2016

(Jenkins is now complaining about the fact that jwt isn't installed.)

Contributor

nikriek commented Mar 28, 2016

Thanks! I'll fix these things if you are ok with the rest.

Contributor

nikriek commented Mar 28, 2016

I'm using PyJWT for JWT decoding, but I can't get it work with Synapse's dependency management.

Owner

erikjohnston commented Mar 29, 2016

@matrixbot ok to test

Owner

erikjohnston commented Mar 29, 2016

LGTM (even jenkins is happy!)

Our unit testing is a bit woeful atm; the bulk of the testing is done via sytest, which is written in Perl. Since this is a fairly simple PR I'm happy to just merge this now and for us to add a sytest for it down the line (unless you're happy writing Perl).

Could you also follow https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#sign-off, i.e. adding Signed-off-by: Your Name <your@email.example.org> to the commit or simply commenting here?

Contributor

nikriek commented Mar 29, 2016

Signed-off-by: Niklas Riekenbrauck nikriek@gmail.com

Contributor

nikriek commented Mar 29, 2016

Thanks!

Owner

erikjohnston commented Mar 29, 2016

Thanks! Feel free to open a PR to add yourself to the AUTHORS.rst.

@erikjohnston erikjohnston merged commit f5bf45a into matrix-org:develop Mar 29, 2016

4 checks passed

Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Merged PR) Build finished.
Details

@nikriek nikriek referenced this pull request Mar 29, 2016

Merged

Add new author #672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment