Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix issues with JWT login #687

Merged
merged 1 commit into from Apr 21, 2016

Conversation

Projects
None yet
3 participants
Contributor

nikriek commented Apr 1, 2016

No description provided.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Owner

erikjohnston commented Apr 1, 2016

@matrixbot ok to test

Contributor

nikriek commented Apr 2, 2016

Give me one day. I thought about adding another configuration parameter.

Owner

erikjohnston commented Apr 14, 2016

Any news?

Contributor

nikriek commented Apr 14, 2016

Jep, few things. I will finish it this weekend!

Owner

erikjohnston commented Apr 14, 2016

No problem! Just checking you're alive :)

Contributor

nikriek commented Apr 19, 2016 edited

Actually I was already done. I thought about adding another config var that allows to change the key to get the user identifier. But in my understanding the sub key should sufficient

Btw: The Flake8 link is invalid.

Owner

erikjohnston commented Apr 19, 2016

Ok cool, will try and have a look tomorrow :)

@matrixbot: test this please

Owner

erikjohnston commented Apr 21, 2016

login.py:229 line is too long.

Other than that it looks good.

Contributor

nikriek commented Apr 21, 2016

Done :)

Owner

erikjohnston commented Apr 21, 2016

(Looks like that test spuriously timed out.)

Thanks for this!

@erikjohnston erikjohnston merged commit b9675ef into matrix-org:develop Apr 21, 2016

3 of 4 checks passed

Sytest Postgres (Merged PR) Build finished.
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Merged PR) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment