/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix stuck invites #691

Merged
merged 1 commit into from Apr 5, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@erikjohnston @NegativeMjark @richvdh @grawity
@erikjohnston
Owner

erikjohnston commented Apr 5, 2016

If rejecting a remote invite fails with an error response don't fail the entire request; instead mark the invite as locally rejected.

This fixes the bug where users can get stuck invites which they can neither accept nor reject.
@erikjohnston
Fix stuck invites 
If rejecting a remote invite fails with an error response don't fail
the entire request; instead mark the invite as locally rejected.

This fixes the bug where users can get stuck invites which they can
neither accept nor reject.

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #288 origin/erikj/member succeeded in 30 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #289 origin/erikj/member succeeded in 4 min 50 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #291 origin/erikj/member succeeded in 3 min 30 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #333 origin/erikj/member succeeded in 1 min 14 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
df727f2

@erikjohnston erikjohnston assigned NegativeMjark Apr 5, 2016

@erikjohnston
Owner

erikjohnston commented Apr 5, 2016

See: matrix-org/sytest#221
@NegativeMjark
Contributor

NegativeMjark commented Apr 5, 2016

LGTM

@erikjohnston erikjohnston merged commit b29f983 into develop Apr 5, 2016
8 checks passed

8 checks passed

Flake8 + Packaging (Commit) Build #288 origin/erikj/member succeeded in 30 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #289 origin/erikj/member succeeded in 4 min 50 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #291 origin/erikj/member succeeded in 3 min 30 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #333 origin/erikj/member succeeded in 1 min 14 sec
Details
Unit Tests (Merged PR) Build finished.
Details

This was referenced Apr 6, 2016

Closed
Closed
@richvdh
Member

richvdh commented Apr 20, 2017

For the record, this landed in synapse 0.15.0-rc1 (2016-04-26), but 0.15.0 wasn't released, so this finally got released in 0.16.0 (2016-06-09).
@grawity

grawity commented Apr 20, 2017

Will it be deployed to matrix.org any time soon, though? Can't wait to get rid of those invites.
@richvdh
Member

richvdh commented Apr 20, 2017

it was deployed to matrix.org over a year ago. If you have stuck invites, it's something else. Please open a new issue.

@grawity grawity referenced this pull request Apr 20, 2017

Closed

Stuck federated invites (again) #2140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment