/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make v2_alpha reg follow the AS API specification #727

Merged
merged 1 commit into from Apr 14, 2016

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@Kegsay @erikjohnston
@Kegsay
Contributor

Kegsay commented Apr 14, 2016

The spec is clear the key should be 'user' not 'username' and this is indeed
the case for v1. This is not true for v2_alpha though, which is what this
commit is fixing.

Manually tested with cURL.
@Kegsay
Make v2_alpha reg follow the AS API specification 
The spec is clear the key should be 'user' not 'username' and this is indeed
the case for v1. This is not true for v2_alpha though, which is what this
commit is fixing.

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #424 origin/kegan/fix-asapi-reg succeeded in 29 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #413 origin/kegan/fix-asapi-reg succeeded in 5 min 56 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #419 origin/kegan/fix-asapi-reg succeeded in 4 min 39 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #468 origin/kegan/fix-asapi-reg succeeded in 1 min 14 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
83776d6

@Kegsay Kegsay assigned erikjohnston Apr 14, 2016

@Kegsay Kegsay added the bug label Apr 14, 2016

@erikjohnston
Owner

erikjohnston commented Apr 14, 2016

LGTM

@Kegsay Kegsay merged commit 4802f9c into develop Apr 14, 2016
8 checks passed

8 checks passed

Flake8 + Packaging (Commit) Build #424 origin/kegan/fix-asapi-reg succeeded in 29 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #413 origin/kegan/fix-asapi-reg succeeded in 5 min 56 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #419 origin/kegan/fix-asapi-reg succeeded in 4 min 39 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #468 origin/kegan/fix-asapi-reg succeeded in 1 min 14 sec
Details
Unit Tests (Merged PR) Build finished.
Details

Kegsay added a commit to matrix-org/matrix-appservice-bridge that referenced this pull request Apr 14, 2016

@Kegsay
Don't use MatrixClient.register() to register users 
Explicitly use v1 AS registration as v2_alpha (r0) is broken as per
matrix-org/synapse#727
d27c5ea

@richvdh richvdh deleted the kegan/fix-asapi-reg branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment