Report per request metrics for all of the things using request_handler #756

NegativeMjark · Apr 28, 2016

No description provided.

Ewwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwwww.

Can we not instead just check if report_metrics is true?

Why can this not be True?

erikjohnston · Apr 28, 2016

LGTM

NegativeMjark assigned erikjohnston Apr 28, 2016

richvdh deleted the markjh/more_metrics branch Dec 1, 2016

@@ -133,6 +142,13 @@ def wrapped_request_handler(self, request):
                              },
                              send_cors=True
                          )
+    +                finally:
+    +                    try:
+    +                        request_metrics.stop(
+    +                            self.clock, request, self.__class__.__name__
+    +                        )
+    +                    except:

@@ -197,19 +213,19 @@ def render(self, request):
              self._async_render(request)
              return server.NOT_DONE_YET
-    -    @request_handler
+    +    @request_handler(report_metrics=False)

matrix-org/synapse