/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Implement basic ignore user API #763

Merged
merged 5 commits into from May 10, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented May 4, 2016

No description provided.

erikjohnston added some commits May 3, 2016

@erikjohnston
Implement basic ignore user

All checks have passed

4 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #581 origin/erikj/ignore_user succeeded in 30 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #565 origin/erikj/ignore_user succeeded in 4 min 26 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #572 origin/erikj/ignore_user succeeded in 3 min 22 sec
Details
@matrixbot
Unit Tests (Commit) — Build #625 origin/erikj/ignore_user succeeded in 1 min 14 sec
Details
a438a6d
@erikjohnston
Merge branch 'develop' of github.com:matrix-org/synapse into erikj/ig… 
…nore_user

Some checks were not successful

1 errored and 7 successful checks
@matrixbot
Sytest Postgres (Commit) — Build #578 origin/erikj/ignore_user failed in 4 min 44 sec
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #594 origin/erikj/ignore_user succeeded in 30 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #585 origin/erikj/ignore_user succeeded in 3 min 14 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #638 origin/erikj/ignore_user succeeded in 1 min 10 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
fee1118
@NegativeMjark
Contributor

NegativeMjark commented May 4, 2016

LGTM

@NegativeMjark NegativeMjark commented on an outdated diff May 4, 2016

View full outdated diff
synapse/storage/account_data.py
@@ -60,6 +63,28 @@ def get_account_data_for_user_txn(txn):
"get_account_data_for_user", get_account_data_for_user_txn
)
+ @cachedInlineCallbacks(num_args=2)
+ def get_global_account_data_by_type_for_user(self, user_id, data_type):
@NegativeMjark

NegativeMjark May 4, 2016 • edited

Contributor

Given how this is used maybe this wants to be a cached list and for the function to take a list of userids rather than a single user?
@NegativeMjark
Contributor

NegativeMjark commented May 5, 2016

Would it be an idea to create a special cached database API for getting the ignore list that could populate the cache with a default empty list if the user hasn't set an ignore list?
@erikjohnston
Owner

erikjohnston commented May 5, 2016

Would it be an idea to create a special cached database API for getting the ignore list that could populate the cache with a default empty list if the user hasn't set an ignore list?

In terms of performance or code neatness?

erikjohnston added some commits May 5, 2016

@erikjohnston
Add bulk fetch storage API

Some checks were not successful

1 errored and 7 successful checks
@matrixbot
Sytest SQLite (Commit) — Build #589 origin/erikj/ignore_user failed in 3 min 29 sec
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #598 origin/erikj/ignore_user succeeded in 31 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #582 origin/erikj/ignore_user succeeded in 4 min 51 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #642 origin/erikj/ignore_user succeeded in 1 min 9 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
1f0f5ff
@erikjohnston
Merge branch 'develop' of github.com:matrix-org/synapse into erikj/ig… 
…nore_user

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #626 origin/erikj/ignore_user succeeded in 33 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #610 origin/erikj/ignore_user succeeded in 4 min 32 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #617 origin/erikj/ignore_user succeeded in 5 min 52 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #670 origin/erikj/ignore_user succeeded in 1 min 11 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
def64d6
@erikjohnston
Merge branch 'develop' of github.com:matrix-org/synapse into erikj/ig… 
…nore_user

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #628 origin/erikj/ignore_user succeeded in 29 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #612 origin/erikj/ignore_user succeeded in 4 min 29 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #619 origin/erikj/ignore_user succeeded in 3 min 20 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #672 origin/erikj/ignore_user succeeded in 1 min 22 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
c9eb6df

@erikjohnston erikjohnston merged commit e581754 into develop May 10, 2016
8 checks passed

8 checks passed

Flake8 + Packaging (Commit) Build #628 origin/erikj/ignore_user succeeded in 29 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #612 origin/erikj/ignore_user succeeded in 4 min 29 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #619 origin/erikj/ignore_user succeeded in 3 min 20 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #672 origin/erikj/ignore_user succeeded in 1 min 22 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the erikj/ignore_user branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment