/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Remove unused indices #782

Merged
merged 3 commits into from May 13, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented May 13, 2016 • edited

This includes removing both unused indices and indices that are subsets of other indices.
@erikjohnston
Remove unused indices 
This includes removing both unused indices and indices that are subsets
of other indices.

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #660 origin/erikj/remove_indices succeeded in 31 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #643 origin/erikj/remove_indices succeeded in 4 min 12 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #651 origin/erikj/remove_indices succeeded in 3 min 8 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #704 origin/erikj/remove_indices succeeded in 1 min 23 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
5e50058

@erikjohnston erikjohnston assigned NegativeMjark May 13, 2016

@NegativeMjark
Annotate the removed indicies with why they were removed.

Some checks were not successful

1 failing and 7 successful checks
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #661 origin/erikj/remove_indices succeeded in 30 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #644 origin/erikj/remove_indices succeeded in 5 min 3 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #652 origin/erikj/remove_indices succeeded in 3 min 38 sec
Details
@matrixbot
Unit Tests (Commit) — Build #705 origin/erikj/remove_indices succeeded in 1 min 17 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
9295fa3

@NegativeMjark NegativeMjark commented on an outdated diff May 13, 2016

View full outdated diff
synapse/storage/schema/delta/32/remove_indices.sql
-- The following indices were unused
+DROP INDEX IF EXISTS remote_media_cache_thumbnails_media_id;
DROP INDEX IF EXISTS evauth_edges_auth_id;
DROP INDEX IF EXISTS topics_room_id;
@NegativeMjark

NegativeMjark May 13, 2016

Contributor

I think that either I'd want to keep this index or get rid of the entire table given that it is write only in synapse, and can be fairly easily constructed from the state tables for ad-hoc queries.
@NegativeMjark
Contributor

NegativeMjark commented May 13, 2016

Other than the topics table it LGTM
@erikjohnston
Remove topics table

All checks have passed

6 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #664 origin/erikj/remove_indices succeeded in 30 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #708 origin/erikj/remove_indices succeeded in 1 min 25 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
c9aff07

@erikjohnston erikjohnston merged commit 024cda9 into develop May 13, 2016
0 of 4 checks passed

0 of 4 checks passed

Flake8 + Packaging (Merged PR) Build triggered. sha1 is merged.
Details
Sytest Postgres (Merged PR) Build triggered. sha1 is merged.
Details
Sytest SQLite (Merged PR) Build triggered. sha1 is merged.
Details
Unit Tests (Merged PR) Build triggered. sha1 is merged.
Details

@richvdh richvdh deleted the erikj/remove_indices branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment