/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

increment badge count per missed convo, not per msg #793

Merged
merged 1 commit into from May 18, 2016

Conversation

Reviewers
No reviews
Assignees

@ara4n ara4n

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ara4n @dbkr
@ara4n
Owner

ara4n commented May 18, 2016

This is a quick fix, but wondering if this lets us significantly simplify the serverside push calculations at all?
@ara4n
increment badge count per missed convo, not per msg

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #715 origin/matthew/one-push-badge-per-convo succeeded in 31 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #695 origin/matthew/one-push-badge-per-convo succeeded in 4 min 38 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #702 origin/matthew/one-push-badge-per-convo succeeded in 3 min 18 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #759 origin/matthew/one-push-badge-per-convo succeeded in 1 min 19 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
e837df6

@ara4n ara4n assigned dbkr May 18, 2016

@dbkr
Member

dbkr commented May 18, 2016

lgtm. Yeah, may be possible to simplify some counting logic, although we still need the counts for each room to send down the stream.

@dbkr dbkr assigned ara4n and unassigned dbkr May 18, 2016

@ara4n ara4n merged commit 6fb51ea into develop May 18, 2016
8 checks passed

8 checks passed

Flake8 + Packaging (Commit) Build #715 origin/matthew/one-push-badge-per-convo succeeded in 31 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #695 origin/matthew/one-push-badge-per-convo succeeded in 4 min 38 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #702 origin/matthew/one-push-badge-per-convo succeeded in 3 min 18 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #759 origin/matthew/one-push-badge-per-convo succeeded in 1 min 19 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the matthew/one-push-badge-per-convo branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment