Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Tune email notifs to make them quieter: #799

Merged
merged 5 commits into from May 24, 2016

Conversation

Projects
None yet
2 participants
Owner

ara4n commented May 23, 2016 edited

  • After initial 10 minute alert from a previously inactive room, only alert every 24h
  • Reset room state back to being inactive after 6h of idleness in the room
  • Synchronise throttles for messages sent in the same notif, so the 24 hourly notifs 'line up'
  • Fix the email subjects to say what triggered the notification
  • Order the rooms in reverse activity order in the email, so the 'reason' room should always come first
  • Send accumulative notifs for all unread notifications, rather than just the delta since the last mail

ara4n added some commits May 23, 2016

Tune email notifs to make them quieter:
 * After initial 10 minute window, only alert every 24h for room notifs
 * Reset room state after 6h of idleness
 * Synchronise throttles for messages sent in the same notif, so the 24 hourly notifs 'line up'
 * Fix the email subjects to say what triggered the notification
 * Order the rooms in reverse activity order in the email, so the 'reason' room should always come first
Owner

ara4n commented May 23, 2016

@dbkr: all yours now.

Member

dbkr commented May 24, 2016

lgtm

@dbkr dbkr merged commit cbf8d14 into develop May 24, 2016

7 of 8 checks passed

Sytest Postgres (Commit) Build #713 origin/matthew/quieter-email-notifs failed in 4 min 54 sec
Details
Flake8 + Packaging (Commit) Build #732 origin/matthew/quieter-email-notifs succeeded in 31 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #720 origin/matthew/quieter-email-notifs succeeded in 3 min 30 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #775 origin/matthew/quieter-email-notifs succeeded in 1 min 25 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the matthew/quieter-email-notifs branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment