Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
special case m.room.third_party_invite event auth to match invites, #814
Conversation
All checks have passed
Flake8 + Packaging (Commit)
— Build #813 origin/matthew/3pid_invite_auth succeeded in 32 sec
Sytest Postgres (Commit)
— Build #788 origin/matthew/3pid_invite_auth succeeded in 4 min 46 sec
Sytest SQLite (Commit)
— Build #795 origin/matthew/3pid_invite_auth succeeded in 3 min 21 sec
ara4n
assigned
erikjohnston
Jun 1, 2016
|
Does this fix the associated sytests? |
|
hadn't spotted broken sytests - are you asking for them to be written, or are there existing disabled broken ones? |
ara4n
added a commit
to matrix-org/sytest
that referenced
this pull request
Jun 2, 2016
|
yes, this fixes the SYN-611 bugs. |
|
LGTM |
ara4n
merged commit c5af1b6
into
develop
Jun 2, 2016
8 checks passed
Flake8 + Packaging (Commit)
Build #813 origin/matthew/3pid_invite_auth succeeded in 32 sec
Details
Flake8 + Packaging (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #788 origin/matthew/3pid_invite_auth succeeded in 4 min 46 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #795 origin/matthew/3pid_invite_auth succeeded in 3 min 21 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
Unit Tests (Commit)
Build #855 origin/matthew/3pid_invite_auth succeeded in 1 min 17 sec
Details
Unit Tests (Merged PR)
Build finished.
Details
richvdh
deleted the
matthew/3pid_invite_auth
branch
Dec 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ara4n commentedJun 1, 2016
otherwise they get out of sync and you get vector-im/vector-web#1208