Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Email unsubscribe links that don't require logging in #821
Conversation
dbkr
added some commits
Jun 1, 2016
All checks have passed
Sytest Postgres (Commit)
— Build #794 origin/dbkr/email_unsubscribe succeeded in 4 min 31 sec
Some checks were not successful
Sytest Postgres (Commit)
— Build #817 origin/dbkr/email_unsubscribe succeeded in 5 min 8 sec
dbkr
assigned
erikjohnston
Jun 2, 2016
|
LGTM, other than PEP8 |
All checks have passed
Sytest Postgres (Commit)
— Build #819 origin/dbkr/email_unsubscribe succeeded in 5 min 0 sec
dbkr
merged commit 6bb9aac
into
develop
Jun 2, 2016
8 checks passed
Flake8 + Packaging (Commit)
Build #845 origin/dbkr/email_unsubscribe succeeded in 33 sec
Details
Flake8 + Packaging (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #819 origin/dbkr/email_unsubscribe succeeded in 5 min 0 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #828 origin/dbkr/email_unsubscribe succeeded in 3 min 30 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
Unit Tests (Commit)
Build #887 origin/dbkr/email_unsubscribe succeeded in 1 min 23 sec
Details
Unit Tests (Merged PR)
Build finished.
Details
richvdh
deleted the
dbkr/email_unsubscribe
branch
Dec 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dbkr commentedJun 2, 2016
Makes the unsubscribe links in emails go direct to a synapse GET API that deletes the pusher in question, authed by a macaroon that allows you to delete pushers and nothing else.
Could do with tests, but the best way to do this would be to add a way of getting delete_pusher macaroons other than receiving them by email, which would probably be an extension to the login API.