/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Change CacheMetrics to be quicker #830

Merged
merged 1 commit into from Jun 3, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Jun 3, 2016

We change it so that each cache has an individual CacheMetric, instead of having one global CacheMetric. This means that when a cache tries to increment a counter it does not need to go through so many indirections.
@erikjohnston
Change CacheMetrics to be quicker 
We change it so that each cache has an individual CacheMetric, instead
of having one global CacheMetric. This means that when a cache tries to
increment a counter it does not need to go through so many indirections.

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #865 origin/erikj/metrics_perf succeeded in 32 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #832 origin/erikj/metrics_perf succeeded in 5 min 48 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #843 origin/erikj/metrics_perf succeeded in 4 min 43 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #905 origin/erikj/metrics_perf succeeded in 1 min 27 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
73c7112

@erikjohnston erikjohnston assigned NegativeMjark Jun 3, 2016

@NegativeMjark
Contributor

NegativeMjark commented Jun 3, 2016

LGTM

@erikjohnston erikjohnston merged commit 43b7f37 into develop Jun 3, 2016
8 checks passed

8 checks passed

Flake8 + Packaging (Commit) Build #865 origin/erikj/metrics_perf succeeded in 32 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #832 origin/erikj/metrics_perf succeeded in 5 min 48 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #843 origin/erikj/metrics_perf succeeded in 4 min 43 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #905 origin/erikj/metrics_perf succeeded in 1 min 27 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the erikj/metrics_perf branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment