/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Change the way we cache events #836

Merged
merged 2 commits into from Jun 3, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Jun 3, 2016

No description provided.

@erikjohnston erikjohnston assigned NegativeMjark Jun 3, 2016

@NegativeMjark NegativeMjark commented on an outdated diff Jun 3, 2016

View full outdated diff
synapse/storage/events.py
@@ -949,14 +957,17 @@ def _get_event_from_row(self, internal_metadata, js, redacted,
desc="_get_event_from_row",
)
- ev = FrozenEvent(
+ origianl_ev = FrozenEvent(
@NegativeMjark

NegativeMjark Jun 3, 2016

Contributor

Spelling?

erikjohnston added some commits Jun 3, 2016

@erikjohnston
Change the way we cache events

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #902 origin/erikj/change_event_cache succeeded in 31 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #862 origin/erikj/change_event_cache succeeded in 5 min 32 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #874 origin/erikj/change_event_cache succeeded in 4 min 12 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #942 origin/erikj/change_event_cache succeeded in 1 min 17 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
10ea3f4
@erikjohnston
Don't rely on options when inserting event into cache

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #905 origin/erikj/change_event_cache succeeded in 32 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #865 origin/erikj/change_event_cache succeeded in 5 min 45 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #877 origin/erikj/change_event_cache succeeded in 4 min 51 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #945 origin/erikj/change_event_cache succeeded in 1 min 20 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
cffe464
@NegativeMjark
Contributor

NegativeMjark commented Jun 3, 2016

LGTM

@erikjohnston erikjohnston merged commit 3210f4c into develop Jun 3, 2016
8 checks passed

8 checks passed

Flake8 + Packaging (Commit) Build #905 origin/erikj/change_event_cache succeeded in 32 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #865 origin/erikj/change_event_cache succeeded in 5 min 45 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #877 origin/erikj/change_event_cache succeeded in 4 min 51 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #945 origin/erikj/change_event_cache succeeded in 1 min 20 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the erikj/change_event_cache branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment