Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make get_domain_from_id throw SynapseError on invalid ID #868

Merged
merged 1 commit into from Jun 14, 2016

Conversation

Projects
None yet
2 participants
Owner

erikjohnston commented Jun 14, 2016

No description provided.

Owner

erikjohnston commented Jun 14, 2016

@matrixbot retest this please

Contributor

NegativeMjark commented Jun 14, 2016

LGTM

@erikjohnston erikjohnston merged commit d12134c into develop Jun 14, 2016

9 of 10 checks passed

Sytest Dendron (Commit) Build #109 origin/erikj/invalid_id failed in 5 min 44 sec
Details
Flake8 + Packaging (Commit) Build #992 origin/erikj/invalid_id succeeded in 33 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #949 origin/erikj/invalid_id succeeded in 5 min 53 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #962 origin/erikj/invalid_id succeeded in 5 min 14 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #1032 origin/erikj/invalid_id succeeded in 1 min 13 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the erikj/invalid_id branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment