Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix TypeError in call to bcrypt.hashpw #873

Merged
merged 1 commit into from Jun 16, 2016

Conversation

Projects
None yet
3 participants
Contributor

vt0r commented Jun 16, 2016 edited

  • At the very least, this TypeError caused logins to fail on my own
    running instance of Synapse, and the simple (explicit) UTF-8
    conversion resolved login errors for me.

Signed-off-by: Salvatore LaMendola salvatore.lamendola@gmail.com

Relevant stack trace bits from when the error was encountered:

  File "/usr/lib/python2.7/dist-packages/synapse/handlers/auth.py", line 629, in validate_hash
    return bcrypt.hashpw(password, stored_hash) == stored_hash
  File "/usr/lib/python2.7/dist-packages/bcrypt/__init__.py", line 57, in hashpw
    raise TypeError("Unicode-objects must be encoded before hashing")
Fix TypeError in call to bcrypt.hashpw
- At the very least, this TypeError caused logins to fail on my own
  running instance of Synapse, and the simple (explicit) UTF-8
  conversion resolved login errors for me.

Signed-off-by: Salvatore LaMendola <salvatore.lamendola@gmail.com>

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Owner

erikjohnston commented Jun 16, 2016

@matrixbot ok to test

(Sorry for jenkins being spammy)

Owner

erikjohnston commented Jun 16, 2016

Thanks for this!

@erikjohnston erikjohnston merged commit 486b9a6 into matrix-org:develop Jun 16, 2016

5 checks passed

Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Merged PR) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment