/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Put most recent 20 messages in notif #892

Merged
merged 3 commits into from Jun 23, 2016

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dbkr @erikjohnston
@dbkr
Member

dbkr commented Jun 22, 2016

Fixes vector-im/vector-web#1648
@dbkr
Put most recent 20 messages in notif 
Fixes vector-im/riot-web#1648

Some checks were not successful

1 failing and 9 successful checks
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #1045 origin/dbkr/email_notif_most_recent succeeded in 32 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #161 origin/dbkr/email_notif_most_recent succeeded in 5 min 55 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #1001 origin/dbkr/email_notif_most_recent succeeded in 5 min 26 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1015 origin/dbkr/email_notif_most_recent succeeded in 4 min 50 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1085 origin/dbkr/email_notif_most_recent succeeded in 1 min 18 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
3a4120e

@dbkr dbkr assigned erikjohnston Jun 22, 2016

@erikjohnston erikjohnston commented on an outdated diff Jun 22, 2016

View full outdated diff
synapse/storage/event_push_actions.py
@@ -191,7 +192,7 @@ def get_no_receipt(txn):
"actions": json.loads(row[3]),
"received_ts": row[4],
} for row in after_read_receipt + no_read_receipt
- ])
+ ][0:limit])
@erikjohnston

erikjohnston Jun 22, 2016

Owner

Generally you write [:limit], but no biggie
@erikjohnston
Owner

erikjohnston commented Jun 22, 2016

LGTM, assuming tests pass

dbkr added some commits Jun 22, 2016

@dbkr
Style

Some checks were not successful

1 errored, 1 failing, and 8 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #162 origin/dbkr/email_notif_most_recent failed in 5 min 38 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #1046 origin/dbkr/email_notif_most_recent succeeded in 34 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1002 origin/dbkr/email_notif_most_recent succeeded in 5 min 5 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1016 origin/dbkr/email_notif_most_recent succeeded in 5 min 55 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1086 origin/dbkr/email_notif_most_recent succeeded in 1 min 19 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
f73fdb0
@dbkr
Actually we need to order these properly 
otherwise we'll end up returning the wrong 20

Some checks were not successful

1 failing and 9 successful checks
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #1047 origin/dbkr/email_notif_most_recent succeeded in 36 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #163 origin/dbkr/email_notif_most_recent succeeded in 6 min 42 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #1003 origin/dbkr/email_notif_most_recent succeeded in 6 min 25 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1017 origin/dbkr/email_notif_most_recent succeeded in 5 min 34 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1087 origin/dbkr/email_notif_most_recent succeeded in 1 min 30 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
b5fb745
@dbkr
Member

dbkr commented Jun 22, 2016

Sorry, realised this wouldn't work: it would end up not returning the most recent 20. This should be a bit better.
@erikjohnston
Owner

erikjohnston commented Jun 22, 2016

LGTM

@dbkr dbkr merged commit 13517e2 into develop Jun 23, 2016
9 of 10 checks passed

9 of 10 checks passed

Sytest Dendron (Merged PR) Build finished.
Details
Flake8 + Packaging (Commit) Build #1047 origin/dbkr/email_notif_most_recent succeeded in 36 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #163 origin/dbkr/email_notif_most_recent succeeded in 6 min 42 sec
Details
Sytest Postgres (Commit) Build #1003 origin/dbkr/email_notif_most_recent succeeded in 6 min 25 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #1017 origin/dbkr/email_notif_most_recent succeeded in 5 min 34 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #1087 origin/dbkr/email_notif_most_recent succeeded in 1 min 30 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the dbkr/email_notif_most_recent branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment