Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Follow up to adding password pepper #910
Conversation
KentShikama
added some commits
Jul 6, 2016
matrixbot
commented
Jul 6, 2016
|
Can one of the admins verify this patch? |
matrixbot
commented
Jul 6, 2016
|
Can one of the admins verify this patch? |
matrixbot
commented
Jul 6, 2016
|
Can one of the admins verify this patch? |
matrixbot
commented
Jul 6, 2016
|
Can one of the admins verify this patch? |
matrixbot
commented
Jul 6, 2016
|
Can one of the admins verify this patch? |
|
Aha, thanks :) |
erikjohnston
merged commit 2e3c8ac
into
matrix-org:develop
Jul 6, 2016
KentShikama
deleted the
KentShikama:hash_password_followup
branch
Jul 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
KentShikama commentedJul 6, 2016
Ran using config with bcrypt rounds 10 and pepper "hello" with password "random"
Tested with
Ran without passing in config with password "random"
Tested with
Ran with non-existing config
Ran with config that didn't contain pepper again with password "random" with bcrypt rounds 10
Tested with