/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Ensure that the guest user is in the database when upgrading accounts #914

Merged
merged 2 commits into from Jul 8, 2016

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@NegativeMjark @erikjohnston
@NegativeMjark
Contributor

NegativeMjark commented Jul 8, 2016

No description provided.

@NegativeMjark
Ensure that the guest user is in the database when upgrading accounts

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #1116 origin/markjh/upgrade succeeded in 36 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #231 origin/markjh/upgrade succeeded in 6 min 11 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1071 origin/markjh/upgrade succeeded in 5 min 38 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1090 origin/markjh/upgrade succeeded in 4 min 42 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1155 origin/markjh/upgrade succeeded in 1 min 28 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
10c843f

@NegativeMjark NegativeMjark assigned erikjohnston Jul 8, 2016

@erikjohnston erikjohnston commented on the diff Jul 8, 2016

View full changes
synapse/storage/registration.py
@@ -127,11 +127,24 @@ def _register(
try:
if was_guest:
+ # Ensure that the guest user actually exists
@erikjohnston

erikjohnston Jul 8, 2016

Owner

Can you comment that we are relying on the allow_none=False, behaviour?

@NegativeMjark

NegativeMjark Jul 8, 2016

Contributor

Done dfde67a
@NegativeMjark
Add a comment explaining allow_none

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #1117 origin/markjh/upgrade succeeded in 32 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #232 origin/markjh/upgrade succeeded in 6 min 8 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1072 origin/markjh/upgrade succeeded in 5 min 18 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1091 origin/markjh/upgrade succeeded in 5 min 46 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1156 origin/markjh/upgrade succeeded in 1 min 24 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
dfde67a
@erikjohnston
Owner

erikjohnston commented Jul 8, 2016

lgtm

@NegativeMjark NegativeMjark merged commit 10f4856 into develop Jul 8, 2016
10 checks passed

10 checks passed

Flake8 + Packaging (Commit) Build #1117 origin/markjh/upgrade succeeded in 32 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #232 origin/markjh/upgrade succeeded in 6 min 8 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #1072 origin/markjh/upgrade succeeded in 5 min 18 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #1091 origin/markjh/upgrade succeeded in 5 min 46 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #1156 origin/markjh/upgrade succeeded in 1 min 24 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the markjh/upgrade branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment