Various auth.py fixes. #919

erikjohnston · Jul 13, 2016

No description provided.

Maybe add a comment to explain why we can do do_sig_check=False here?

NegativeMjark · Jul 15, 2016

LGTM

erikjohnston assigned NegativeMjark Jul 13, 2016

richvdh deleted the erikj/auth_fix branch Dec 1, 2016

@@ -379,7 +379,7 @@ def _resolve_auth_events(self, events, auth_events):
                  try:
                      # FIXME: hs.get_auth() is bad style, but we need to do it to
                      # get around circular deps.
-    -                self.hs.get_auth().check(event, auth_events)
+    +                self.hs.get_auth().check(event, auth_events, do_sig_check=False)

@@ -391,7 +391,7 @@ def _resolve_normal_events(self, events, auth_events):
                  try:
                      # FIXME: hs.get_auth() is bad style, but we need to do it to
                      # get around circular deps.
-    -                self.hs.get_auth().check(event, auth_events)
+    +                self.hs.get_auth().check(event, auth_events, do_sig_check=False)

@@ -918,7 +918,7 @@ def on_make_leave_request(self, room_id, user_id):
              )
              try:
-    -            self.auth.check(event, auth_events=context.current_state)
+    +            self.auth.check(event, auth_events=context.current_state, do_sig_check=False)

@@ -688,7 +688,7 @@ def on_make_join_request(self, room_id, user_id):
                  logger.warn("Failed to create join %r because %s", event, e)
                  raise e
-    -        self.auth.check(event, auth_events=context.current_state)
+    +        self.auth.check(event, auth_events=context.current_state, do_sig_check=False)

matrix-org/synapse