Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Fall back to 'username' if 'user' is not given for appservice registration. #927
Conversation
matrixbot
commented
Jul 16, 2016
|
Can one of the admins verify this patch? |
matrixbot
commented
Jul 16, 2016
|
Can one of the admins verify this patch? |
matrixbot
commented
Jul 16, 2016
|
Can one of the admins verify this patch? |
matrixbot
commented
Jul 16, 2016
|
Can one of the admins verify this patch? |
matrixbot
commented
Jul 16, 2016
|
Can one of the admins verify this patch? |
|
ok to test |
erikjohnston
and 1 other
commented on an outdated diff
Jul 16, 2016
synapse/rest/client/v2_alpha/register.py
| @@ -134,9 +134,11 @@ def on_POST(self, request): | ||
| # fallback to 'username' if they gave one. | ||
| if isinstance(body.get("user"), basestring): | ||
| desired_username = body["user"] |
erikjohnston
Owner
|
Half-Shot
added some commits
Jul 16, 2016
|
LGTM. Can you sign off the commit? |
|
Signed-off-by: Will Hunt half-shot@molrams.com |
erikjohnston
merged commit 4f81edb
into
matrix-org:develop
Jul 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Half-Shot commentedJul 16, 2016
It's stated in the comments that (quite sensibly) we should fallback to 'username' if user isn't given, yet this didn't appear to be implemented. This allows for either key with a preference for 'user'.