Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Record device_id in client_ips #938
Conversation
Some checks were not successful
Sytest Dendron (Commit)
— Build #301 origin/rav/add_device_id_to_client_ips failed in 1 min 34 sec
Flake8 + Packaging (Commit)
— Build #1187 origin/rav/add_device_id_to_client_ips succeeded in 34 sec
Sytest Postgres (Commit)
— Build #1138 origin/rav/add_device_id_to_client_ips succeeded in 5 min 55 sec
Sytest SQLite (Commit)
— Build #1160 origin/rav/add_device_id_to_client_ips succeeded in 6 min 1 sec
Unit Tests (Commit)
— Build #1226 origin/rav/add_device_id_to_client_ips succeeded in 2 min 10 sec
richvdh
assigned
erikjohnston and
dbkr
and unassigned
erikjohnston
Jul 20, 2016
|
LGTM |
richvdh
merged commit e9e3eaa
into
develop
Jul 20, 2016
12 of 15 checks passed
SynapseSytestDendronPR
Build #178 detached failed in 2 min 50 sec
Details
Sytest Dendron (Commit)
Build #301 origin/rav/add_device_id_to_client_ips failed in 1 min 34 sec
Details
Sytest Dendron (Merged PR)
Build finished.
Details
Flake8 + Packaging (Commit)
Build #1187 origin/rav/add_device_id_to_client_ips succeeded in 34 sec
Details
Flake8 + Packaging (Merged PR)
Build finished.
Details
SynapseFlake8Packaging
Build #693 detached succeeded in 37 sec
Details
SynapseSytestPostgresPR
Build #697 detached succeeded in 6 min 41 sec
Details
SynapseSytestSQLitePR
Build #701 detached succeeded in 6 min 6 sec
Details
SynapseUnittests
Build #692 detached succeeded in 2 min 10 sec
Details
Sytest Postgres (Commit)
Build #1138 origin/rav/add_device_id_to_client_ips succeeded in 5 min 55 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #1160 origin/rav/add_device_id_to_client_ips succeeded in 6 min 1 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
Unit Tests (Commit)
Build #1226 origin/rav/add_device_id_to_client_ips succeeded in 2 min 10 sec
Details
Unit Tests (Merged PR)
Build finished.
Details
richvdh
deleted the
rav/add_device_id_to_client_ips
branch
Jul 20, 2016
richvdh
added a commit
that referenced
this pull request
Jul 20, 2016
Some checks were not successful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
richvdh commentedJul 20, 2016
Record the device_id when we add a client ip; it's somewhat redundant as we
could get it via the access_token, but it will make querying rather easier.