/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Send the correct host header when fetching keys #941

Merged
merged 3 commits into from Jul 28, 2016

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Jul 21, 2016

No description provided.

erikjohnston added some commits Jul 21, 2016

@erikjohnston
Send the correct host header when fetching keys

Some checks were not successful

3 errored, 3 failing, and 4 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #309 origin/erikj/key_client_fix failed in 1 min 30 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #1146 origin/erikj/key_client_fix failed in 5 min 33 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #1169 origin/erikj/key_client_fix failed in 4 min 49 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #1195 origin/erikj/key_client_fix succeeded in 35 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1234 origin/erikj/key_client_fix succeeded in 2 min 14 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
081e5d5
@erikjohnston
Set host not path

Some checks were not successful

1 errored, 1 failing, and 8 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #311 origin/erikj/key_client_fix failed in 1 min 36 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #1197 origin/erikj/key_client_fix succeeded in 39 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1148 origin/erikj/key_client_fix succeeded in 6 min 32 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1171 origin/erikj/key_client_fix succeeded in 6 min 10 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1236 origin/erikj/key_client_fix succeeded in 2 min 29 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
cf94a78

@erikjohnston erikjohnston assigned NegativeMjark Jul 21, 2016

@NegativeMjark
Contributor

NegativeMjark commented Jul 21, 2016

LGTM

@NegativeMjark NegativeMjark commented on an outdated diff Jul 21, 2016

View full outdated diff
synapse/crypto/keyclient.py
@@ -124,7 +123,10 @@ def handleResponse(self, response_body_bytes):
self.timer.cancel()
def on_timeout(self):
- logger.debug("Timeout waiting for response from %s", self.host)
+ logger.debug(
+ "Timeout waiting for response from %s: %s",
+ self.host, self.transport.getPeer(),
@NegativeMjark

NegativeMjark Jul 21, 2016

Contributor

You can't call getPeer() here cause the connection might have disappeared.
@erikjohnston
Cache getPeer

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #1210 origin/erikj/key_client_fix succeeded in 35 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #322 origin/erikj/key_client_fix succeeded in 7 min 25 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1158 origin/erikj/key_client_fix succeeded in 6 min 41 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1181 origin/erikj/key_client_fix succeeded in 6 min 19 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1247 origin/erikj/key_client_fix succeeded in 2 min 20 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
d26b660
@NegativeMjark
Contributor

NegativeMjark commented Jul 22, 2016

Actually LGTM

@NegativeMjark NegativeMjark assigned erikjohnston and unassigned NegativeMjark Jul 28, 2016

@erikjohnston erikjohnston merged commit 78cac3e into develop Jul 28, 2016
10 checks passed

10 checks passed

Flake8 + Packaging (Commit) Build #1210 origin/erikj/key_client_fix succeeded in 35 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #322 origin/erikj/key_client_fix succeeded in 7 min 25 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #1158 origin/erikj/key_client_fix succeeded in 6 min 41 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #1181 origin/erikj/key_client_fix succeeded in 6 min 19 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #1247 origin/erikj/key_client_fix succeeded in 2 min 20 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the erikj/key_client_fix branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment