/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Preserve device_id from first call to /register #942

Merged
merged 1 commit into from Jul 21, 2016

Conversation

Reviewers
No reviews
Assignees

@dbkr dbkr

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@richvdh @dbkr
@richvdh
Member

richvdh commented Jul 21, 2016

device_id may only be passed in the first call to /register, so make sure we
fish it out of the register params rather than the body of the final call.

(a sytest for this is coming)
@richvdh
Preserve device_id from first call to /register 
device_id may only be passed in the first call to /register, so make sure we
fish it out of the register `params` rather than the body of the final call.

Some checks were not successful

1 errored, 1 failing, and 8 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #310 origin/rav/fix_register_deviceid failed in 1 min 25 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #1196 origin/rav/fix_register_deviceid succeeded in 33 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1147 origin/rav/fix_register_deviceid succeeded in 5 min 48 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1170 origin/rav/fix_register_deviceid succeeded in 4 min 53 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1235 origin/rav/fix_register_deviceid succeeded in 2 min 7 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
1a64dff

@richvdh richvdh assigned dbkr Jul 21, 2016

@dbkr dbkr merged commit 1e6e370 into develop Jul 21, 2016
8 of 10 checks passed

8 of 10 checks passed

Sytest Dendron (Commit) Build #310 origin/rav/fix_register_deviceid failed in 1 min 25 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Flake8 + Packaging (Commit) Build #1196 origin/rav/fix_register_deviceid succeeded in 33 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #1147 origin/rav/fix_register_deviceid succeeded in 5 min 48 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #1170 origin/rav/fix_register_deviceid succeeded in 4 min 53 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #1235 origin/rav/fix_register_deviceid succeeded in 2 min 7 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the rav/fix_register_deviceid branch Oct 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment