/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Implement GET /device/{deviceId} #943

Merged
merged 2 commits into from Jul 21, 2016

Conversation

Reviewers
No reviews
Assignees

@dbkr dbkr

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@richvdh @dbkr
@richvdh
Member

richvdh commented Jul 21, 2016 • edited

This turns out to be reasonably useful for the sytests.
@richvdh
Implement GET /device/{deviceId}

Some checks were not successful

2 errored, 2 failing, and 6 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #1201 origin/rav/get_device_api failed in 33 sec
Details
@matrixbot
Sytest Dendron (Commit) — Build #314 origin/rav/get_device_api failed in 1 min 33 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1150 origin/rav/get_device_api succeeded in 6 min 50 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1173 origin/rav/get_device_api succeeded in 6 min 18 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1239 origin/rav/get_device_api succeeded in 2 min 32 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
406f7aa

@richvdh richvdh assigned dbkr Jul 21, 2016

@richvdh
Fix PEP8 errors

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #1202 origin/rav/get_device_api succeeded in 38 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #315 origin/rav/get_device_api succeeded in 6 min 14 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1151 origin/rav/get_device_api succeeded in 5 min 50 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1174 origin/rav/get_device_api succeeded in 5 min 38 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1240 origin/rav/get_device_api succeeded in 2 min 18 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
1c3c202
@dbkr
Member

dbkr commented Jul 21, 2016

Is there spec for this coming?
@richvdh
Member

richvdh commented Jul 21, 2016

There will be. Currently it's in https://docs.google.com/document/d/1H8Z5b9kGKuvFkfDR1uQHaKdYxBD03ZDjMGH1IXQ0Wbw/edit. Per https://github.com/matrix-org/matrix-doc/blob/master/CONTRIBUTING.rst#specification-changes, it has to go into server and clients, first.

That's why it's only on /unstable...

@dbkr dbkr merged commit 2c28e25 into develop Jul 21, 2016
10 checks passed

10 checks passed

Flake8 + Packaging (Commit) Build #1202 origin/rav/get_device_api succeeded in 38 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #315 origin/rav/get_device_api succeeded in 6 min 14 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #1151 origin/rav/get_device_api succeeded in 5 min 50 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #1174 origin/rav/get_device_api succeeded in 5 min 38 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #1240 origin/rav/get_device_api succeeded in 2 min 18 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the rav/get_device_api branch Oct 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment