Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Implement updates and deletes for devices #949
Conversation
richvdh
added some commits
Jul 21, 2016
richvdh
assigned
dbkr
Jul 26, 2016
dbkr
merged commit d34e9f9
into
develop
Jul 26, 2016
10 checks passed
Flake8 + Packaging (Commit)
Build #1230 origin/rav/update_devices succeeded in 34 sec
Details
Flake8 + Packaging (Merged PR)
Build finished.
Details
Sytest Dendron (Commit)
Build #341 origin/rav/update_devices succeeded in 7 min 33 sec
Details
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #1176 origin/rav/update_devices succeeded in 7 min 8 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #1201 origin/rav/update_devices succeeded in 6 min 35 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
Unit Tests (Commit)
Build #1267 origin/rav/update_devices succeeded in 2 min 17 sec
Details
Unit Tests (Merged PR)
Build finished.
Details
richvdh
deleted the
rav/update_devices
branch
Jul 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
richvdh commentedJul 25, 2016
When we delete a device, we want to invalidate access tokens associated with it. This not only requires some new indices; it also requires some hacking around a race condition to try and stop access tokens being added without there being device records to back them.