Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Forbid non-ASes from registering users whose names begin with '_' #958
Conversation
Some checks were not successful
leonerd
assigned
erikjohnston
Jul 27, 2016
leonerd
referenced this pull request
in matrix-org/sytest
Jul 27, 2016
Merged
Test that ASes may begin user IDs with '_'; normal users cannot #272
|
What's the motivation? |
|
LGTM, providing that this is something that has been agreed we should do. (Though a config option would be great too) |
leonerd
merged commit 18b7eb8
into
develop
Jul 29, 2016
7 of 10 checks passed
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Merged PR)
Build finished.
Details
Flake8 + Packaging (Commit)
Build #1255 origin/paul/SYN-738 succeeded in 34 sec
Details
Flake8 + Packaging (Merged PR)
Build finished.
Details
Sytest Dendron (Commit)
Build #364 origin/paul/SYN-738 succeeded in 7 min 3 sec
Details
Sytest Postgres (Commit)
Build #1200 origin/paul/SYN-738 succeeded in 6 min 41 sec
Details
Sytest SQLite (Commit)
Build #1225 origin/paul/SYN-738 succeeded in 5 min 37 sec
Details
Unit Tests (Commit)
Build #1292 origin/paul/SYN-738 succeeded in 2 min 21 sec
Details
Unit Tests (Merged PR)
Build finished.
Details
richvdh
deleted the
paul/SYN-738
branch
Dec 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
leonerd commentedJul 27, 2016
•
edited
This code path is not involved when ASes register users, so ASes will still be able to make use of this prefix.
Tested by matrix-org/sytest#272