/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Create separate methods for getting messages to push #966

Merged
merged 2 commits into from Jul 29, 2016

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@NegativeMjark @erikjohnston
@NegativeMjark
Contributor

NegativeMjark commented Jul 28, 2016

for the email and http pushers rather than trying to make a single
method that will work with their conflicting requirements.

The http pusher needs to get the messages in ascending stream order, and
doesn't want to miss a message.

The email pusher needs to get the messages in descending timestamp order,
and doesn't mind if it misses messages.
@NegativeMjark
Create separate methods for getting messages to push 
for the email and http pushers rather than trying to make a single
method that will work with their conflicting requirements.

The http pusher needs to get the messages in ascending stream order, and
doesn't want to miss a message.

The email pusher needs to get the messages in descending timestamp order,
and doesn't mind if it misses messages.

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #1284 origin/markjh/fix_push succeeded in 38 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #390 origin/markjh/fix_push succeeded in 7 min 21 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1226 origin/markjh/fix_push succeeded in 6 min 54 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1254 origin/markjh/fix_push succeeded in 5 min 55 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1321 origin/markjh/fix_push succeeded in 2 min 13 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
0a7d3cd

@NegativeMjark NegativeMjark assigned erikjohnston Jul 28, 2016

@NegativeMjark
Fix SQL to supply arguments in the same order

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #1285 origin/markjh/fix_push succeeded in 38 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #391 origin/markjh/fix_push succeeded in 7 min 45 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1227 origin/markjh/fix_push succeeded in 7 min 22 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1255 origin/markjh/fix_push succeeded in 6 min 25 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1322 origin/markjh/fix_push succeeded in 2 min 26 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
8dad08a
@erikjohnston
Owner

erikjohnston commented Jul 29, 2016

LGTM

@NegativeMjark NegativeMjark merged commit a679a01 into develop Jul 29, 2016
10 checks passed

10 checks passed

Flake8 + Packaging (Commit) Build #1285 origin/markjh/fix_push succeeded in 38 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #391 origin/markjh/fix_push succeeded in 7 min 45 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #1227 origin/markjh/fix_push succeeded in 7 min 22 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #1255 origin/markjh/fix_push succeeded in 6 min 25 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #1322 origin/markjh/fix_push succeeded in 2 min 26 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the markjh/fix_push branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment