Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Fix adding emails on registration #968
Conversation
Some checks were not successful
Sytest Dendron (Commit)
— Build #399 origin/dbkr/fix_add_email_on_register failed in 7 min 49 sec
Sytest Postgres (Commit)
— Build #1235 origin/dbkr/fix_add_email_on_register failed in 7 min 14 sec
Sytest SQLite (Commit)
— Build #1263 origin/dbkr/fix_add_email_on_register failed in 5 min 45 sec
Flake8 + Packaging (Commit)
— Build #1293 origin/dbkr/fix_add_email_on_register succeeded in 36 sec
Unit Tests (Commit)
— Build #1330 origin/dbkr/fix_add_email_on_register succeeded in 2 min 17 sec
dbkr
assigned
richvdh
Jul 29, 2016
|
LGTM, modulo the test fails |
richvdh
assigned
dbkr
and unassigned
richvdh
Jul 29, 2016
All checks have passed
Flake8 + Packaging (Commit)
— Build #1300 origin/dbkr/fix_add_email_on_register succeeded in 32 sec
Sytest Dendron (Commit)
— Build #406 origin/dbkr/fix_add_email_on_register succeeded in 7 min 34 sec
Sytest Postgres (Commit)
— Build #1242 origin/dbkr/fix_add_email_on_register succeeded in 7 min 33 sec
Sytest SQLite (Commit)
— Build #1270 origin/dbkr/fix_add_email_on_register succeeded in 5 min 18 sec
Unit Tests (Commit)
— Build #1337 origin/dbkr/fix_add_email_on_register succeeded in 2 min 12 sec
dbkr
merged commit 26a8c1d
into
develop
Aug 2, 2016
9 of 10 checks passed
Sytest Postgres (Merged PR)
Build started sha1 is merged.
Details
Flake8 + Packaging (Commit)
Build #1300 origin/dbkr/fix_add_email_on_register succeeded in 32 sec
Details
Flake8 + Packaging (Merged PR)
Build finished.
Details
Sytest Dendron (Commit)
Build #406 origin/dbkr/fix_add_email_on_register succeeded in 7 min 34 sec
Details
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #1242 origin/dbkr/fix_add_email_on_register succeeded in 7 min 33 sec
Details
Sytest SQLite (Commit)
Build #1270 origin/dbkr/fix_add_email_on_register succeeded in 5 min 18 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
Unit Tests (Commit)
Build #1337 origin/dbkr/fix_add_email_on_register succeeded in 2 min 12 sec
Details
Unit Tests (Merged PR)
Build finished.
Details
richvdh
deleted the
dbkr/fix_add_email_on_register
branch
Dec 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dbkr commentedJul 29, 2016
Synapse was not adding email addresses to accounts registered with an email address, due to too many different variables called 'result'. Rename both of them. Also remove the defer.returnValue() with no params because that's not a thing.