Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Ignore AlreadyCalled errors on timer cancel #970

Merged
merged 1 commit into from Aug 2, 2016

Conversation

Projects
None yet
2 participants
Owner

erikjohnston commented Jul 31, 2016

This causes /pusher/set to occasionally 500, leading android falling back to keeping a connection open.

Member

dbkr commented Aug 1, 2016

lgtm apart from the test failures

@dbkr dbkr assigned erikjohnston and unassigned dbkr Aug 1, 2016

Owner

erikjohnston commented Aug 2, 2016

@matrixbot retest this please

@erikjohnston erikjohnston merged commit f14cd95 into develop Aug 2, 2016

7 of 10 checks passed

Sytest Dendron (Commit) Build #402 origin/erikj/clock failed in 7 min 41 sec
Details
Sytest Postgres (Commit) Build #1238 origin/erikj/clock failed in 7 min 8 sec
Details
Sytest SQLite (Commit) Build #1266 origin/erikj/clock failed in 5 min 58 sec
Details
Flake8 + Packaging (Commit) Build #1296 origin/erikj/clock succeeded in 40 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #1333 origin/erikj/clock succeeded in 2 min 24 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the erikj/clock branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment