/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Ensure we only persist an event once at a time #975

Merged
merged 2 commits into from Aug 3, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Aug 3, 2016

No description provided.

@erikjohnston
Ensure we only persist an event once at a time

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #1329 origin/erikj/multi_event_persist succeeded in 40 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #433 origin/erikj/multi_event_persist succeeded in 8 min 43 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1267 origin/erikj/multi_event_persist succeeded in 7 min 40 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1297 origin/erikj/multi_event_persist succeeded in 6 min 38 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1366 origin/erikj/multi_event_persist succeeded in 2 min 17 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
a8a32d2

@erikjohnston erikjohnston assigned NegativeMjark Aug 3, 2016

@NegativeMjark
Contributor

NegativeMjark commented Aug 3, 2016 • edited

LGTM. Does mean we can get rid of the other bit of de-duplication that happens in persist event?

https://github.com/matrix-org/synapse/blob/develop/synapse/storage/events.py#L439
@erikjohnston
Remove other bit of deduplication

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #1333 origin/erikj/multi_event_persist succeeded in 38 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #437 origin/erikj/multi_event_persist succeeded in 9 min 3 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1271 origin/erikj/multi_event_persist succeeded in 6 min 30 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1301 origin/erikj/multi_event_persist succeeded in 6 min 5 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1370 origin/erikj/multi_event_persist succeeded in 2 min 31 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
80ad710
@NegativeMjark
Contributor

NegativeMjark commented Aug 3, 2016

LGTM

@erikjohnston erikjohnston merged commit f5da3ba into develop Aug 3, 2016
10 checks passed

10 checks passed

Flake8 + Packaging (Commit) Build #1333 origin/erikj/multi_event_persist succeeded in 38 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #437 origin/erikj/multi_event_persist succeeded in 9 min 3 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #1271 origin/erikj/multi_event_persist succeeded in 6 min 30 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #1301 origin/erikj/multi_event_persist succeeded in 6 min 5 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #1370 origin/erikj/multi_event_persist succeeded in 2 min 31 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the erikj/multi_event_persist branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment