/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Retry event persistence on IntegrityError #983

Merged
merged 2 commits into from Aug 4, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Aug 4, 2016

Due to a bug in the porting script some backfilled events were not correctly persisted, causing irrecoverable IntegrityErrors on future attempts to persist those events.

This commit adds a retry mechanism invoked upon IntegrityError, where when retried the tables are urged for all references to the events being persisted.

erikjohnston added some commits Aug 4, 2016

@erikjohnston
Retry event persistence on IntegrityError 
Due to a bug in the porting script some backfilled events were not
correctly persisted, causing irrecoverable IntegrityErrors on future
attempts to persist those events.

This commit adds a retry mechanism invoked upon IntegrityError,
where when retried the tables are purged for all references to the
events being persisted.

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #1361 origin/erikj/retry_on_integrity_error succeeded in 58 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #460 origin/erikj/retry_on_integrity_error succeeded in 9 min 51 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1293 origin/erikj/retry_on_integrity_error succeeded in 6 min 41 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1326 origin/erikj/retry_on_integrity_error succeeded in 4 min 24 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1398 origin/erikj/retry_on_integrity_error succeeded in 2 min 33 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
59fa91f
@erikjohnston
Fix typo

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #1362 origin/erikj/retry_on_integrity_error succeeded in 33 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #461 origin/erikj/retry_on_integrity_error succeeded in 8 min 32 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1294 origin/erikj/retry_on_integrity_error succeeded in 6 min 19 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1327 origin/erikj/retry_on_integrity_error succeeded in 5 min 45 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1399 origin/erikj/retry_on_integrity_error succeeded in 2 min 33 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
8ad8490

@erikjohnston erikjohnston assigned NegativeMjark Aug 4, 2016

@NegativeMjark
Contributor

NegativeMjark commented Aug 4, 2016

LGTM

@erikjohnston erikjohnston merged commit 835ceee into develop Aug 4, 2016
10 checks passed

10 checks passed

Flake8 + Packaging (Commit) Build #1362 origin/erikj/retry_on_integrity_error succeeded in 33 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #461 origin/erikj/retry_on_integrity_error succeeded in 8 min 32 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #1294 origin/erikj/retry_on_integrity_error succeeded in 6 min 19 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #1327 origin/erikj/retry_on_integrity_error succeeded in 5 min 45 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #1399 origin/erikj/retry_on_integrity_error succeeded in 2 min 33 sec
Details
Unit Tests (Merged PR) Build finished.
Details

This was referenced Aug 5, 2016

Merged
Closed

@richvdh richvdh deleted the erikj/retry_on_integrity_error branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment