/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Check if we already have the events returned by /state/ #986

Merged
merged 2 commits into from Aug 5, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Aug 5, 2016

No description provided.

@erikjohnston
Check if we already have the events returned by /state/

All checks have passed

9 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #1369 origin/erikj/state succeeded in 43 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1300 origin/erikj/state succeeded in 6 min 21 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1334 origin/erikj/state succeeded in 5 min 20 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1405 origin/erikj/state succeeded in 2 min 37 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
fccadb7

@erikjohnston erikjohnston assigned NegativeMjark Aug 5, 2016

@NegativeMjark
Contributor

NegativeMjark commented Aug 5, 2016

LGTM

@NegativeMjark NegativeMjark commented on an outdated diff Aug 5, 2016

View full outdated diff
synapse/federation/federation_client.py
)
signed_auth = yield self._check_sigs_and_hash_and_fetch(
- destination, auth_chain, outlier=True
+ destination,
+ [p for p in pdus if p.event_id not in auth_chain],
@NegativeMjark

NegativeMjark Aug 5, 2016

Contributor

Should this be seen_events rather than auth_chain?
@erikjohnston
Fix typo

All checks have passed

10 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #1371 origin/erikj/state succeeded in 41 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Dendron (Commit) — Build #469 origin/erikj/state succeeded in 8 min 49 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #1302 origin/erikj/state succeeded in 6 min 41 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #1336 origin/erikj/state succeeded in 5 min 2 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #1407 origin/erikj/state succeeded in 2 min 7 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
2d4de61

@erikjohnston erikjohnston merged commit 9377509 into develop Aug 5, 2016
10 checks passed

10 checks passed

Flake8 + Packaging (Commit) Build #1371 origin/erikj/state succeeded in 41 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Dendron (Commit) Build #469 origin/erikj/state succeeded in 8 min 49 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #1302 origin/erikj/state succeeded in 6 min 41 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #1336 origin/erikj/state succeeded in 5 min 2 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #1407 origin/erikj/state succeeded in 2 min 7 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the erikj/state branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment